feat(anta): Add support of CSV file export #672

titom73 · 2024-05-13T16:18:10Z

Description

Add option to save tests result in CSV format

Command example

# Example 1
anta nrfu -c anta/nrfu.yml csv --csv-output demo.csv

# Example 2
anta nrfu -c anta/nrfu.yml --device spine1 csv --csv-output demo.csv

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)

Requirements

PR fix(anta.cli): Update --hide description under anta nrfu #750 before updating documentation with anta nrfu --help output

mtache · 2024-05-14T10:14:06Z

What about anta nrfu csv ? :)

titom73 · 2024-05-14T15:59:01Z

What about anta nrfu csv ? :)

It means would have no output which is a bit uncommon: running tests and not seing results.

This aproach assumes that you can chose how you want to display and just save results in a CSV file.

github-actions · 2024-07-04T14:03:48Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-07-05T07:26:59Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

for more information, see https://pre-commit.ci

…loud

anta/cli/nrfu/commands.py

Co-authored-by: Carl Baillargeon <[email protected]>

sonarcloud · 2024-07-10T10:24:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

anta/reporter/csv_reporter.py

docs/cli/nrfu.md

tests/units/reporter/test_csv.py

Co-authored-by: Guillaume Mulocher <[email protected]>

for more information, see https://pre-commit.ci

anta/cli/nrfu/commands.py

anta/reporter/csv_reporter.py

docs/cli/nrfu.md

tests/units/reporter/test_csv.py

anta/cli/nrfu/utils.py

sonarcloud · 2024-07-17T13:43:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

carl-baillargeon

LGTM

feat(anta): Add support of CSV file export

c272163

titom73 added framework-enhancement New feature or request Anta CLI All things around CLI labels May 13, 2024

titom73 requested review from mtache, gmuloc and carl-baillargeon May 13, 2024 16:18

titom73 self-assigned this May 13, 2024

titom73 and others added 4 commits May 16, 2024 10:01

fix(anta.cli): Move --save-to-csv at NRFU level

daa60d2

fix(anta.cli): rename csv option to --csv-output

9cdf026

Merge branch 'main' into feat/csv-export

12e7b67

Merge branch 'main' into feat/csv-export

b4bf68e

github-actions bot added the state: conflict label Jul 4, 2024

carl-baillargeon mentioned this pull request Jul 4, 2024

Reporting enchancements #717

Open

Merge branch 'main' into feat/csv-export

66c812e

github-actions bot removed the state: conflict label Jul 5, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

c8266e9

for more information, see https://pre-commit.ci

titom73 mentioned this pull request Jul 5, 2024

feat(anta): Add Markdown report option to ANTA #740

Merged

6 tasks

titom73 added 2 commits July 5, 2024 10:10

fix(anta.reporter): Define constants to manage table headers - sonarc…

4e16158

…loud

fix(anta.reporter): Define constants to manage table headers - sonarc…

13a6b48

…loud

titom73 force-pushed the feat/csv-export branch from 5fefdce to 13a6b48 Compare July 5, 2024 08:34

titom73 and others added 4 commits July 5, 2024 13:20

Merge branch 'main' into feat/csv-export

dd4d0ab

refactor: Move to a click command for csv

09b6577

refactor: ReportCsv to dedicated module

bf501e2

Merge branch 'main' into feat/csv-export

030c502

carl-baillargeon reviewed Jul 5, 2024

View reviewed changes

anta/cli/nrfu/commands.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed Jul 5, 2024

View reviewed changes

anta/cli/nrfu/commands.py Show resolved Hide resolved

titom73 and others added 2 commits July 10, 2024 12:21

Update tests/units/reporter/test_csv.py

c35d721

Co-authored-by: Carl Baillargeon <[email protected]>

Update tests/units/cli/nrfu/test_commands.py

ef2bab7

Co-authored-by: Carl Baillargeon <[email protected]>

gmuloc requested changes Jul 10, 2024

View reviewed changes

anta/reporter/csv_reporter.py Outdated Show resolved Hide resolved

anta/reporter/csv_reporter.py Outdated Show resolved Hide resolved

docs/cli/nrfu.md Outdated Show resolved Hide resolved

tests/units/reporter/test_csv.py Outdated Show resolved Hide resolved

titom73 and others added 5 commits July 10, 2024 15:05

Update anta/reporter/csv_reporter.py

e9be744

Co-authored-by: Guillaume Mulocher <[email protected]>

Update anta/reporter/csv_reporter.py

ccbce5f

Co-authored-by: Guillaume Mulocher <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

c6c3a50

for more information, see https://pre-commit.ci

ci: Cleanup pytest

20d63c7

fix: Update cli help message

8173f2a

titom73 requested a review from gmuloc July 10, 2024 14:10

titom73 added 3 commits July 10, 2024 16:49

fix: Increase coverage: multiline

469496f

fix: Update code

c572d85

fix: Update code

0a8f952

gmuloc reviewed Jul 12, 2024

View reviewed changes

anta/cli/nrfu/commands.py Outdated Show resolved Hide resolved

gmuloc reviewed Jul 12, 2024

View reviewed changes

anta/reporter/csv_reporter.py Outdated Show resolved Hide resolved

docs/cli/nrfu.md Outdated Show resolved Hide resolved

tests/units/reporter/test_csv.py Outdated Show resolved Hide resolved

titom73 added 2 commits July 12, 2024 18:27

fix: Remove useless comment in CLI help message

1ad77d7

update as per code review

a8626b6

titom73 requested a review from gmuloc July 16, 2024 13:09

titom73 and others added 3 commits July 16, 2024 16:33

fix: Capture error when opening CSV file

e4a0197

doc: Fix doc

61a5629

Refactor: Add test for OSError when writing csv report

00beea2

gmuloc reviewed Jul 17, 2024

View reviewed changes

anta/cli/nrfu/utils.py Outdated Show resolved Hide resolved

gmuloc reviewed Jul 17, 2024

View reviewed changes

anta/cli/nrfu/utils.py Outdated Show resolved Hide resolved

Apply suggestions from code review

d92d829

gmuloc approved these changes Jul 17, 2024

View reviewed changes

Test: Avoid creating test.csv in repo

3baf7ae

carl-baillargeon approved these changes Jul 17, 2024

View reviewed changes

gmuloc merged commit 25ec15f into aristanetworks:main Jul 17, 2024
19 checks passed

github-actions bot added the rn: feat(anta) label Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(anta): Add support of CSV file export #672

feat(anta): Add support of CSV file export #672

titom73 commented May 13, 2024 •

edited

Loading

mtache commented May 14, 2024

titom73 commented May 14, 2024

github-actions bot commented Jul 4, 2024

github-actions bot commented Jul 5, 2024

sonarcloud bot commented Jul 10, 2024

sonarcloud bot commented Jul 17, 2024

carl-baillargeon left a comment

feat(anta): Add support of CSV file export #672

feat(anta): Add support of CSV file export #672

Conversation

titom73 commented May 13, 2024 • edited Loading

Description

Command example

Checklist:

Requirements

mtache commented May 14, 2024

titom73 commented May 14, 2024

github-actions bot commented Jul 4, 2024

github-actions bot commented Jul 5, 2024

sonarcloud bot commented Jul 10, 2024

Quality Gate passed

sonarcloud bot commented Jul 17, 2024

Quality Gate passed

carl-baillargeon left a comment

Choose a reason for hiding this comment

titom73 commented May 13, 2024 •

edited

Loading